pk_from_sk: Add validation of s1 and s2
#841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
changed the title
pk_from_sk: Add validation of s1 and s2
hanno-becker
reviewed
Jan 5, 2026
mkannwischer
force-pushed
the
validate-sk
branch
2 times, most recently
from
81d158f to
a8738b1
Compare
hanno-becker
reviewed
Jan 5, 2026
hanno-becker
approved these changes
Jan 5, 2026
Contributor
hanno-becker
left a comment
hanno-becker
left a comment
There was a problem hiding this comment.
LGTM, only one nit regarding variable naming
mkannwischer
force-pushed
the
validate-sk
branch
from
a8738b1 to
9a4aacb
Compare
Altenative to #807 This commit adds validation of the s1 and s2 components of the secret key to the pk_from_sk function. It checks if coefficients are within the valid bound [-MLDSA_ETA, MLDSA_ETA] by using the chknorm function that is already present in the code. Documentation and CBMC proofs are adjusted accordingly. Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
force-pushed
the
validate-sk
branch
from
9a4aacb to
ebf11b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altenative to #807 (re-using
chknorminstead of re-implementing a norm check, omitting tests for now).This commit adds validation of the s1 and s2 components of the secret key to the pk_from_sk function. It checks if coefficients are within the valid bound [-MLDSA_ETA, MLDSA_ETA] by using the chknorm function that is already present in the code.
Documentation and CBMC proofs are adjusted accordingly.